Merged
Conversation
added 2 commits
March 1, 2022 13:07
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
added 2 commits
March 1, 2022 14:12
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
added 2 commits
March 1, 2022 14:33
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Contributor
Author
Updated to presentation |
turt2live
approved these changes
Mar 1, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm otherwise, particularly considering code review was approved on the other half
src/@types/svg.d.ts
Outdated
Comment on lines
+2
to
+3
| Copyright 2021 Šimon Brandner <[email protected]> | ||
| Copyright 2022 The Matrix.org Foundation C.I.C. |
Member
There was a problem hiding this comment.
This copyright looks a bit incorrect - I think it should just be the foundation?
Signed-off-by: Kerry Archibald <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add svgr loader for icons, so they can be imported directly in react.
See matrix-org/matrix-react-sdk#7928 for more context
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.